Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): add helperText and errorText properties #30140

Open
wants to merge 29 commits into
base: feature-8.5
Choose a base branch
from

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jan 20, 2025

Issue number: resolves #29810


What is the current behavior?

Checkbox does not support helper and error text.

What is the new behavior?

Adds support for helper and error text, similar to input and textarea.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 10:02pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Jan 20, 2025
@@ -287,6 +298,46 @@ input {
@include transform-origin(center, top);
}

// Justify Content
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't make changes to any of this code I just moved it lower so it would take priority over the justify-content I specified in label-placement-end.

@brandyscarney brandyscarney marked this pull request as ready for review January 28, 2025 21:50
@brandyscarney brandyscarney requested a review from a team as a code owner January 28, 2025 21:50
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The supporting text being read twice is the main issue. The rest are just questions.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

:host(.checkbox-label-placement-stacked) .checkbox-bottom {
font-size: dynamic-font(16px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above* :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants