refactor(card): add common file and ionic test #29724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -13,6 +13,13 @@ | |||
| <script src="../../../../../scripts/testing/scripts.js"></script> | |||
| <script nomodule src="../../../../../dist/ionic/ionic.js"></script> | |||
| <script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script> | |||
| <script> | |||
There was a problem hiding this comment.
5 of the "theme-ionic" templates use theme="ionic" as an attribute on the html element. We should be consistent.
brandyscarney
approved these changes
Jul 24, 2024
|
I think this will have conflicts with #29757 which I was going to merge soon |
|
Closing since this has been done through another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The file style structure for card does not follow the new structure containing the common styles.
What is the new behavior?
ionictheme to the basic test.ionictest page to always be set toionic.Does this introduce a breaking change?
Other information
Preview