Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump ionicons from 7.1.0 to 7.1.2 in /core #27540

Closed
wants to merge 5 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 23, 2023

Bumps ionicons from 7.1.0 to 7.1.1.

Release notes

Sourced from ionicons's releases.

v7.1.1

7.1.1 (2023-05-23)

Bug Fixes

  • icon: respond to changes of document dir (#1210) (e70bf21)
Changelog

Sourced from ionicons's changelog.

7.1.1 (2023-05-23)

Bug Fixes

  • icon: respond to changes of document dir (#1210) (e70bf21)
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [ionicons](https://github.com/ionic-team/ionicons) from 7.1.0 to 7.1.1.
- [Release notes](https://github.com/ionic-team/ionicons/releases)
- [Changelog](https://github.com/ionic-team/ionicons/blob/main/CHANGELOG.md)
- [Commits](ionic-team/ionicons@v7.1.0...v7.1.1)

---
updated-dependencies:
- dependency-name: ionicons
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner May 23, 2023 18:27
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 23, 2023
@stackblitz
Copy link

stackblitz bot commented May 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label May 23, 2023
@mapsandapps
Copy link
Contributor

I'm guessing these screenshots are showing diffs because Playwright is not using Safari 16.4+ as needed for :dir

@liamdebeasi liamdebeasi force-pushed the dependabot/npm_and_yarn/core/ionicons-7.1.1 branch from 2602047 to 7286d97 Compare May 26, 2023 02:03
@liamdebeasi
Copy link
Contributor

We should wait for ionic-team/ionicons#1223 to ship before merging this PR

return result[1];
/**
* Set the direction before the tests start
* to avoid https://bugs.webkit.org/show_bug.cgi?id=257133
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add a tech debt ticket to remove this once the bug has been fixed/released in Safari and Playwright has been updated.

Copy link
Contributor

@mapsandapps mapsandapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for figuring this out!

i'm going to "request changes" since we don't want to merge this yet. as mentioned above, the needed changes are:

  • fix issues with ionicons, ship 7.1.2, and update this PR to use the new version
  • make a tech debt ticket

@liamdebeasi liamdebeasi changed the title chore(deps): Bump ionicons from 7.1.0 to 7.1.1 in /core chore(deps): Bump ionicons from 7.1.0 to 7.1.2 in /core May 30, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 30, 2023

A newer version of ionicons exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@liamdebeasi
Copy link
Contributor

liamdebeasi commented Aug 3, 2023

Closing in favor of updating this in the feature-7.3 branch: #27925

@liamdebeasi liamdebeasi closed this Aug 3, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 3, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/core/ionicons-7.1.1 branch August 3, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants