Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add canDismiss support for card modals #24920

Merged
merged 7 commits into from
Mar 11, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Part of #22297

What is the new behavior?

  • This adds the canDismiss implementation for card modals

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner March 10, 2022 20:18
@github-actions github-actions bot added the package: core @ionic/core package label Mar 10, 2022
@liamdebeasi liamdebeasi changed the title feat(modal): add canDismiss support for card feat(modal): add canDismiss support for card modals Mar 10, 2022
@sean-perkins sean-perkins self-requested a review March 10, 2022 21:38
@liamdebeasi liamdebeasi changed the base branch from candismiss-base to FW-286 March 11, 2022 17:43
@liamdebeasi liamdebeasi merged commit 7c17f98 into FW-286 Mar 11, 2022
@liamdebeasi liamdebeasi deleted the candismiss-card branch March 11, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants