Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status-bar): tapping status bar now correctly scrolls content to top #24001

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #20423

What is the new behavior?

  • Tapping status bar now interrupts momentum scrolling and scrolls the page to the top.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@EinfachHans
Copy link
Contributor

@liamdebeasi this fixes it for status bar taps, but not for the scrollToTop() function itself, i guess it would be better to fix it in there? For example: I use Tabs and have a workaround to scroll up on click on a active tab again. So I use the content function in there and have the same experience

@liamdebeasi
Copy link
Contributor Author

The scrollToTop function is old code and not very well tested at the moment. Diving in to make sure that all of these scrolling methods still work properly would take quite a bit of time, and I think it is more important to have the status tap working, which is a fundamental piece of functionality for any mobile app. On top of that, we are looking to leverage more of the browser's smooth scrolling functionality rather than our own custom logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: status bar scroll to top does not fully cancel content scroll
2 participants