fix(ios): fix retain cycle caused by CDVPluginManager #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ginmanager breaks a retain cycle
Steven0351
requested review from
markemer,
EiyuuZack,
Chuckytuh,
jcesarmobile,
theproducer and
usernuno
jcesarmobile
approved these changes
Oct 2, 2024
andredestro
approved these changes
Oct 2, 2024
Steven0351
added a commit
that referenced
this pull request
Oct 2, 2024
Steven0351
added a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strong reference to the
UIViewControllerandWKWebViewowned by Capacitor causes a retain cycle that does not allow for anything to be released from memory when using Cordova plugins. This issue isn't present in typical Capacitor applications, but any scenario where aCAPBridgeViewControllerthat uses Cordova plugins is presented will stay in memory even when the view controller is dismissed.