feat(android): Fix for #6258, add Huawei webview support #6306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giralte-ionic
changed the title
giralte-ionic
changed the title
giralte-ionic
requested review from
theproducer,
IT-MikeS,
ItsChaceD,
jcesarmobile and
markemer
and removed request for
theproducer
|
Seems like this is failing lint, |
markemer
requested changes
Mar 14, 2023
|
PR #6402 supersedes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add Huawei webview support in minimal Android webview check. Also add ability to specify minimum supported Huawei webview version.
Huawei webview use different versioning, the minimum i found is 10.x.x.x. Current is 12.x.x.x. So i set minimal version 10. Have tested on Honor 10 device with installed 11 and 12 Huawei webview.
Close #6258