Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Avoid ConcurrentModificationException on notifyListeners #5125

Merged
merged 2 commits into from
Oct 13, 2021
Merged

fix(android): Avoid ConcurrentModificationException on notifyListeners #5125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8a4059
fix(android): Avoid ConcurrentModificationException on notifyListeners
jcesarmobile Oct 13, 2021
d751159
fmt
jcesarmobile Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion android/capacitor/src/main/java/com/getcapacitor/Plugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.Locale;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.CopyOnWriteArrayList;
import org.json.JSONException;

/**
Expand Down Expand Up @@ -668,7 +669,8 @@ protected void notifyListeners(String eventName, JSObject data, boolean retainUn
return;
}

for (PluginCall call : listeners) {
CopyOnWriteArrayList<PluginCall> listenersCopy = new CopyOnWriteArrayList(listeners);
for (PluginCall call : listenersCopy) {
call.resolve(data);
}
}
Expand Down