fix(ios): Add CDVScreenOrientationDelegate protocol on CAPBridgeViewController #5070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2021
elylucas
approved these changes
Sep 24, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Cordova plugins, such as cordova-plugin-inappbrowser rely on CDVScreenOrientationDelegate to determine its supported orientations.
CAPBridgeViewController.swift can't conform CDVScreenOrientationDelegate directly because the CDVScreenOrientationDelegate protocol Objective-C names conflict with UIViewController names in Swift.
This PR adds an Objective-C category for CAPBridgeViewController that allows to conform CDVScreenOrientationDelegate, and since it's Objective-C it doesn't conflict.