Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS): Renaming scrolling flag #4441

Merged
merged 6 commits into from
Apr 29, 2021
Merged

feat(iOS): Renaming scrolling flag #4441

merged 6 commits into from
Apr 29, 2021

Conversation

ikeith
Copy link
Contributor

@ikeith ikeith commented Apr 6, 2021

As per the discussion on 4416, this change was unrelated and has been moved to a separate PR.

This branch renames the programmatic config property from enableScrolling to scrollingEnabled. It now better matches the loggingEnabled property as well as the config file option and the actual setting on WKWebView.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but let's try to not merge it until right before we are about to do a new release so it doesn't break keyboard plugin

@ikeith ikeith merged commit 69e07ae into main Apr 29, 2021
@ikeith ikeith deleted the renaming branch April 29, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants