fix(core): do not add window.cordova on web apps

[elylucas]

I wrapped the logic in the legacy handlers to only add the empty Cordova object and the native event handlers to only be executed when it is running on a device. This fixes the issue with Ionic Core wrongly identifying web apps as being identified as Cordova and hybrid apps as brought up in issue #4198.

[lincolnthree]

Glad I'm not crazy. I thought I was losing my mind for a while, trying to track down what I'd done that had caused this to start happening. Thanks for the fix!

[imhoffd]

@lincolnthree Thank you for reporting it!

[lincolnthree]

Hey @dwieeb, did this make it into the beta.3 build? Tried it out and it looks like the compiled sources do not include the fix:

sharktop:topdecked-unified lincoln$ npx cap doctor
💊   Capacitor Doctor  💊 

Latest Dependencies:

  @capacitor/cli: 2.4.6
  @capacitor/core: 2.4.6
  @capacitor/android: 2.4.6
  @capacitor/ios: 2.4.6

Installed Dependencies:

  @capacitor/cli: 3.0.0-beta.3
  @capacitor/core: 3.0.0-beta.3
  @capacitor/android: 3.0.0-beta.3
  @capacitor/ios: 3.0.0-beta.3

[success] iOS looking great! 👌
[success] Android looking great! 👌
sharktop:topdecked-unified lincoln$ 

[lincolnthree]

Actually hang on. I think there's some weird caching going on here. I see the updated dist/ in node_modules, but the ionic serve code does not seem to reflect the change, even with cache disabled in browser.

[lincolnthree]

Okay, confirmed! This is working :) Was a weird NPM multi-version precedence thing... Thanks again!