chore: bump targetSdkVersion and compileSdkVersion to 30 #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhoffd
approved these changes
Dec 23, 2020
|
nevermind, we already merged iOS one as a chore |
LeviticusMB
added a commit
to Onslip/capacitor-android-v16
that referenced
this pull request
Nov 7, 2022
See: * commit:26f6a64e (ionic-team#3981) * commit:4442459b (ionic-team#5442) * commit:8793c58f (ionic-team#5443) * commit:e1b7f49d (ionic-team#5457) * commit:8b8be470 (ionic-team#5612) * commit:416b9662 (ionic-team#5611) * commit:79b4a3c5 (ionic-team#5351) * commit:f3022a30 (ionic-team#3739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in variables.gradle, capacitor and capacitor-cordova-android-plugins
Added QueryPermissionsNeeded lint suppress because that it used for input file and getUserMedia, but most users won't use it, so adding intent queries on Capacitor's manifest wouldn't be a good idea.
But we would need to document somewhere that for Android 11, users need to add those queries if using input file and/or getUserMedia (not sure where would be the better place for that)