feat(android): share both text and url at the same time #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works great, thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
This is a minor refactor that allows to share a file (a url that starts with
file:) with text on android. I noticed that the ios version already supports this functionality.I'm not sure if this is considered a "breaking change" but if it gets merged it will affect what is shared on the following scenario:
urlandtextBefore fix: It will only share the file
After fix: it will share the file and will also have text if the receiving app supports it.
Demo:
https://drive.google.com/file/d/141Q0G3hA2tf8n5k_rNMc7WkhJClrle6i/view?usp=sharing
All feedback is welcome :)
Have fun