Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: cookie handling for proxied requests + avoid creating a new connection to check the contentType #2836

Closed
wants to merge 2 commits into from
Closed

Conversation

goapilz
Copy link

@goapilz goapilz commented Apr 27, 2020

Fixes #2831
When using the "server.url" parameter in the capacitor.config.json to retrieve the app data from an external server incoming cookies are not saved to the CookieManager. Also an additional connection is opened in handleProxyRequest to check the contentType.

see: WebViewLocalServer:handleProxyRequest
see: JSInjector:getInjectedStream

My scenario:
Currently I use capacitor to add a native barcode scanner to my PWA app.
When running as simple PWA, the "browser camera api" is used, but when running in the capacitor app the native barcode scanner should be used.
Therefore capacitor seems to be the perfect framework.
But currently i have the described problem when the authentication cookie should be saved.

I would be happy if my change would be included in the project.

see issue:
#2831

@jcesarmobile
Copy link
Member

Thanks for the PR
I've sent two separate PRs based on yours since they are 2 different problems and some changes weren't needed.
(#3078 and #3076)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Android: cookie handling for proxied requests + avoid creating a new connection to check the contentType
2 participants