Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): use appName as package.json name on electron project #2741

Merged
merged 6 commits into from Apr 10, 2020
Merged

fix(cli): use appName as package.json name on electron project #2741

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50a1773
Update Electron Add CLI
IT-MikeS Apr 10, 2020
c09241f
Update cli/src/electron/add.ts
Apr 10, 2020
948baab
Update cli/src/electron/add.ts
Apr 10, 2020
221344a
Update cli/src/electron/add.ts
Apr 10, 2020
11c6fcc
Update cli/src/electron/add.ts
Apr 10, 2020
866acb4
Update cli/src/electron/add.ts
Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cli/src/electron/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
import { exec } from 'child_process';
import { Config } from '../config';
import { copyTemplate, hasYarn, installDeps, runTask } from '../common';
import { writeFileSync } from '../util/fs';
import { join } from 'path';

export async function addElectron(config: Config) {

await runTask(`Adding Electron project in: ${config.electron.platformDir}`, async () => {
return copyTemplate(config.electron.assets.templateDir, config.electron.platformDir);
const copyReturn = await copyTemplate(config.electron.assets.templateDir, config.electron.platformDir);
const capConfigName = require(join(config.app.rootDir, 'capacitor.config.json')).appName;
const packageJSONParse = require(join(config.electron.platformDir, 'package.json'));
packageJSONParse.name = capConfigName;
writeFileSync(join(config.electron.platformDir, 'package.json'), JSON.stringify(packageJSONParse));
return copyReturn;
});

await runTask(`Installing NPM Dependencies`, async () => {
Expand Down