Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(update guide): fix targetSdkVersion instructions #2585

Merged
merged 1 commit into from
Mar 17, 2020
Merged

docs(update guide): fix targetSdkVersion instructions #2585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions site/docs-md/android/updating.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Recommended changes:
Since we have common variables, it's recommended to update your project to use them. In the `android/app/build.gradle` file, change:
- `compileSdkVersion 28` to `compileSdkVersion rootProject.ext.compileSdkVersion`
- `minSdkVersion 21` to `minSdkVersion rootProject.ext.minSdkVersion`
- `targetSdkVersion 28` to `rootProject.ext.targetSdkVersion`
- `targetSdkVersion 28` to `targetSdkVersion rootProject.ext.targetSdkVersion`
- `implementation 'androidx.appcompat:appcompat:1.0.0'` to `implementation "androidx.appcompat:appcompat:$androidxAppCompatVersion"`
- `testImplementation 'junit:junit:4.12'` to `testImplementation "junit:junit:$junitVersion"`
- `androidTestImplementation 'androidx.test.ext:junit:1.1.1'` to `androidTestImplementation "androidx.test.ext:junit:$androidxJunitVersion"`
Expand All @@ -121,4 +121,4 @@ Recommended changes:

In `android/build.gradle` file, change `classpath 'com.google.gms:google-services:4.2.0'` to `classpath 'com.google.gms:google-services:4.3.3'`.

For API changes check the [Release Notes](https://github.com/ionic-team/capacitor/releases/tag/2.0.0-beta.0)
For API changes check the [Release Notes](https://github.com/ionic-team/capacitor/releases/tag/2.0.0-beta.0)