fix(ios): implement statusTap for iOS 13 #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
added
the
needs discussion
jcesarmobile
removed
the
needs discussion
jcesarmobile
changed the title
jcesarmobile
force-pushed
the
statusbar-fix-swizzle
branch
from
6afe64e
to
60ac760
Compare
Proper-Job
reviewed
Mar 3, 2020
| }); | ||
| } | ||
|
|
||
| -(void)nofity_handleTapAction:(id)arg1 { |
There was a problem hiding this comment.
Is this a typo or intentionally spelled wrong?
|
Isn't handleTapAction: a private API? |
|
We are technically not using it, just listening for its invocation. We have used similar approaches in different Cordova plugins and Capacitor over the years to workaround other iOS bugs without problems. But if Apple ever rejects or warns about it, we would remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use swizzling to implement statusTap for iOS 13
closes #2109