fix(android-livereload-localhost): #1776
Conversation
* Use request proxy handler when livereload and appUrl localhost:8100 * Reconnect when connection has not been established
luisvt
force-pushed
the
fix-android-livereload-localhost
branch
from
37c05f6 to
a32fa60
Compare
|
Thanks, but this only works on simulators, on real devices it will try to proxy localhost:8100, and that will fail because "localhost" will be the device, but the server is in the computer. I think Ionic CLI will be updated to use |
|
yes, the objective is also to let the user add the port fordwarding in the chrome inspector |
|
When I run livereload using |
|
Ah, didn't think about port forwarding. |
| @@ -173,10 +173,11 @@ public WebResourceResponse shouldInterceptRequest(WebResourceRequest request) { | |||
| return null; | |||
| } | |||
|
|
|||
| if (isLocalFile(loadingUrl) || loadingUrl.toString().startsWith(bridge.getLocalUrl())) { | |||
| if (isLocalFile(loadingUrl) || !bridge.getAppUrl().contains("localhost:8100") && loadingUrl.toString().startsWith(bridge.getLocalUrl())) { | |||
There was a problem hiding this comment.
this is not a good check, will stop working if the user changes the default port. It's probably better to just check Config.getString("server.url") == null
|
|
||
| HttpURLConnection conn; | ||
| boolean isContentTypeNull; | ||
| do { |
There was a problem hiding this comment.
I'm not really confortable putting a while with Thread.sleep, might be useful for reconnection, but could cause problems if the networks is down.
There was a problem hiding this comment.
If there is a better way you could point me, I'll change it.
There was a problem hiding this comment.
Maybe I could throw an error after 10 attempts
This will allow users run:
and let connect the app to
localhost:8100without the need to use--address=0.0.0.0