Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(plugins): add @rdlabo/capacitor-admob #1739

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

rdlabo
Copy link
Contributor

@rdlabo rdlabo commented Jul 5, 2019

This is forked from capacitor-admob , because capacitor-admob worked only capacitor/android@beta only.

@jcesarmobile
Copy link
Member

Can't you send a PR to the original plugin to get it fixed?

Not sure if we should start listing forks

@rdlabo
Copy link
Contributor Author

rdlabo commented Jul 15, 2019

@jcesarmobile Thanks for response.
I didn't sent PR. Because checked Issues of this repository, and all issues had not response... So I created another package, not PR,
I created big changes. Not only bug fix for android, I created Web and iOS API, and changed package name.
(* If the repository is maintained even a little, I created PR. ex: capacitor-firebase-analytics )

@jcesarmobile
Copy link
Member

I think it's still worth a try, if you send the PR and he doesn't merge it in a while I'll remove that one and add your fork instead.

@rdlabo
Copy link
Contributor Author

rdlabo commented Aug 4, 2019

@jcesarmobile Thanks for comment.
16 days ago, I created smallest pull request for working in current capacitor version.
rahadur/capacitor-admob#10

@jcesarmobile jcesarmobile merged commit bb16b4b into ionic-team:master Aug 6, 2019
@rahadur
Copy link
Contributor

rahadur commented Aug 7, 2019

Hello @rdlabo I sincerely apologize for the delay in response. First of all thank you for your support. I marge your Pull request and capacitor-admob failed to build. i found that Capacitor Team update their Plugins folder structure, here i am updating this plugins from scratch. I hope within few hour i am going to publish a new version.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants