Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(keyboard): move import before usage in sample code #1702

Merged
merged 2 commits into from
Jun 25, 2019
Merged

docs(keyboard): move import before usage in sample code #1702

merged 2 commits into from
Jun 25, 2019

Conversation

danielsogl
Copy link
Contributor

No description provided.

jcesarmobile
jcesarmobile requested changes Jun 24, 2019
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import is already in the example, but in the API part, can you move it up instead of duplicating? (the whole API part before the events part)

@danielsogl
Copy link
Contributor Author

Done :)

@jcesarmobile jcesarmobile changed the title docs(keyboard): add missing import to example code docs(keyboard): move import before usage Jun 25, 2019
@jcesarmobile jcesarmobile changed the title docs(keyboard): move import before usage docs(keyboard): move import before usage in sample code Jun 25, 2019
@jcesarmobile jcesarmobile merged commit 7606328 into ionic-team:master Jun 25, 2019
@danielsogl danielsogl deleted the patch-1 branch June 25, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielsogl @jcesarmobile