Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add more community guides to APIs and comm guides pages #1594

Merged
merged 1 commit into from
May 30, 2019

Conversation

dotNetkow
Copy link
Contributor

  • Community Guides page: adding APIs as a new subsection and link Paul’s Network post. Others in the future.

  • Individual API pages: If content is explicitly about an API (like Paul’s on Network - https://developer.school/posts/ionic-4-network-detection-with-capacitor/), then link to it here too. Add header Example Guides to existing ones that could use it.

We get the best of both worlds and account for multiple ways that devs could be viewing the docs, for the lowest effort.

@dotNetkow dotNetkow requested review from mlynch and jcesarmobile May 29, 2019 01:21
@jcesarmobile
Copy link
Member

I don't really like linking external guides from the APIs section, nor linking our own internal guides from the Community section.

@mlynch
Copy link
Contributor

mlynch commented May 30, 2019

I think this is reasonable. Let's try it and see how it feels for a bit. If we find the content gets out of date or whatnot we will need to rethink.

@jcesarmobile jcesarmobile force-pushed the docs-moar-community branch from d7817ab to 64c6796 Compare May 30, 2019 14:04
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've fixed the conflicts, will merge once tests finish

@jcesarmobile jcesarmobile changed the title Added more community guides to APIs and comm guides pages Docs: Add more community guides to APIs and comm guides pages May 30, 2019
@jcesarmobile jcesarmobile merged commit 36dee58 into master May 30, 2019
@jcesarmobile jcesarmobile deleted the docs-moar-community branch May 30, 2019 14:28
@dotNetkow
Copy link
Contributor Author

Thanks Julio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants