feat(android): Allow plugin methods to crash (#2512)

ionic-team · Mar 4, 2020 · 253cdc9 · 253cdc9
1 parent 08a2ebc
commit 253cdc9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/android/capacitor/src/main/java/com/getcapacitor/Bridge.java b/android/capacitor/src/main/java/com/getcapacitor/Bridge.java
@@ -522,10 +522,11 @@ public void run() {
             if (call.isSaved()) {
               saveCall(call);
             }
-          } catch(PluginLoadException | InvalidPluginMethodException | PluginInvocationException ex) {
+          } catch(PluginLoadException | InvalidPluginMethodException ex) {
             Log.e(LOG_TAG, "Unable to execute plugin method", ex);
-          } catch(Exception ex) {
+          } catch (Exception ex) {
             Log.e(LOG_TAG, "Serious error executing plugin", ex);
+            throw new RuntimeException(ex);
           }
         }
       };

diff --git a/android/capacitor/src/main/java/com/getcapacitor/PluginHandle.java b/android/capacitor/src/main/java/com/getcapacitor/PluginHandle.java
@@ -84,7 +84,8 @@ public Plugin load() throws PluginLoadException {
    */
   public void invoke(String methodName, PluginCall call) throws PluginLoadException,
                                                                 InvalidPluginMethodException,
-                                                                PluginInvocationException {
+                                                                InvocationTargetException,
+                                                                IllegalAccessException {
     if(this.instance == null) {
       // Can throw PluginLoadException
       this.load();
@@ -95,11 +96,8 @@ public void invoke(String methodName, PluginCall call) throws PluginLoadExceptio
       throw new InvalidPluginMethodException("No method " + methodName + " found for plugin " + pluginClass.getName());
     }
 
-    try {
-      methodMeta.getMethod().invoke(this.instance, call);
-    } catch(InvocationTargetException | IllegalAccessException ex) {
-      throw new PluginInvocationException("Unable to invoke method " + methodName + " on plugin " + pluginClass.getName(), ex);
-    }
+    methodMeta.getMethod().invoke(this.instance, call);
+
   }
 
   /**