Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Docs: update to reflect logging configuration changes #258

Merged
merged 7 commits into from
May 18, 2021
Merged

Conversation

ikeith
Copy link
Contributor

@ikeith ikeith commented Apr 1, 2021

Documentation companion to ionic-team/capacitor#4416

@vercel
Copy link

vercel bot commented Apr 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

capacitor-site – ./

🔍 Inspect: https://vercel.com/ionic/capacitor-site/Dad2uCsmhGWvUA7CAVSVJJvFEvwE
✅ Preview: https://capacitor-site-git-logging-ionic1.vercel.app

[Deployment for 0febb7e failed]

capacitor-docs – ./

🔍 Inspect: https://vercel.com/ionic/capacitor-docs/D4ijW7xpUHdeyms66AoksCj6V7LM
✅ Preview: Failed

[Deployment for 0335ae7 failed]

capacitor-site-ionic-io – ./

🔍 Inspect: https://vercel.com/ionic/capacitor-site-ionic-io/8jr8bj9hRnDVT53pn22gHqsFFBm8
✅ Preview: https://capacitor-site-ionic-io-git-logging-ionic1.vercel.app

[Deployment for 0febb7e failed]

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config changes should be done on the v3 config docs, you made them on the v2 ones.

Same for console API, but I've noticed that we don't have a console section on v3 (probably because they are now generated from plugins and Console is not a real plugin)

@ikeith
Copy link
Contributor Author

ikeith commented Apr 6, 2021

The config changes should be done on the v3 config docs, you made them on the v2 ones.

Whoops, good catch. Since the Console docs are gone, I've expanded the inline documentation in the declaration file both here and in the main repo.

@ikeith ikeith requested a review from jcesarmobile April 6, 2021 22:16
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Not sure if we might want to leave the hideLogs as it's still there despite it's deprecated, or if it's better to remove it so people don't use it.
We might want to document in the capacitor 3 upgrade guide that hideLogs is deprecated and that they should move to loggingBehavior

@ikeith
Copy link
Contributor Author

ikeith commented May 7, 2021

Updated the upgrade guide.

@jcesarmobile jcesarmobile merged commit 28255af into main May 18, 2021
@jcesarmobile jcesarmobile deleted the logging branch May 18, 2021 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants