Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geolocation): Error if Google Play Services are not available #709

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Nov 29, 2021

Since the plugin relies on the Fused Location Provider, we should return an error if Google Play Services are not available.

At the moment, if they are disabled the plugin doesn't reject nor resolve, just show an ugly message on logcat.

related to #700

Copy link
Member

@carlpoole carlpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jcesarmobile jcesarmobile merged commit fc79c43 into main Nov 29, 2021
@jcesarmobile jcesarmobile deleted the error-no-play branch November 29, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants