Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(local-notifications): Fixed wrong rollup config #528

Merged
merged 1 commit into from
Aug 5, 2021
Merged

fix(local-notifications): Fixed wrong rollup config #528

merged 1 commit into from
Aug 5, 2021

Conversation

trancee
Copy link
Contributor

@trancee trancee commented Jul 25, 2021

I tried to use the latest version of the Local Notifications plugin by linking the dist/plugin.js and it turns out the configuration of this plugin is wrong. Instead of using capacitorLocalNotifications it was set to capacitorHaptics and instead of using the globals capacitorExports it was using capacitorLocalNotifications.

Console output:

capacitor-local-notifications.js:150 Uncaught ReferenceError: capacitorLocalNotifications is not defined
    at capacitor-local-notifications.js:150
(anonymous) @ capacitor-local-notifications.js:150

@jcesarmobile jcesarmobile changed the title fix(local-notifications): Fixed wrong rollup config for Local Notifications plugin. fix(local-notifications): Fixed wrong rollup config Aug 5, 2021
jcesarmobile
jcesarmobile approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@jcesarmobile jcesarmobile merged commit cd17daa into ionic-team:main Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trancee @jcesarmobile