feat(android): implements Activity Result API changes for permissions and activity results #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpoole
commented
Jan 28, 2021
...droid/src/main/java/com/capacitorjs/plugins/localnotifications/LocalNotificationsPlugin.java
Show resolved
Hide resolved
imhoffd
reviewed
Jan 29, 2021
share/android/src/main/java/com/capacitorjs/plugins/share/SharePlugin.java
Outdated
Show resolved
Hide resolved
jcesarmobile
requested changes
Feb 4, 2021
share/android/src/main/java/com/capacitorjs/plugins/share/SharePlugin.java
Outdated
Show resolved
Hide resolved
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
jcesarmobile
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to implement changes to the Activity Results API and permission requests, see: ionic-team/capacitor#4127
permissionCallbackelement from the@PluginMethodannotation. The permission result callback methods are now annotated directly with@PermissionCallbackand the method name is passed in at request time.@ActivityCallbackmethods.