Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing ints #214

Merged
merged 1 commit into from
Jan 28, 2021
Merged

add missing ints #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion local-notifications/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ The object that describes a local notification.

| Prop | Type | Description | Since |
| -------- | ------------------- | ---------------------------- | ----- |
| **`id`** | <code>string</code> | The notification identifier. | 1.0.0 |
| **`id`** | <code>number</code> | The notification identifier. | 1.0.0 |


#### ScheduleOptions
Expand Down
2 changes: 1 addition & 1 deletion local-notifications/ios/Plugin/LocalNotificationsHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public class LocalNotificationsHandler: NSObject, NotificationHandlerProtocol {
func makeNotificationRequestJSObject(_ request: UNNotificationRequest) -> JSObject {
let notificationRequest = notificationRequestLookup[request.identifier] ?? [:]
return [
"id": request.identifier,
"id": Int(request.identifier) ?? -1,
"title": request.content.title,
"sound": notificationRequest["sound"] ?? "",
"body": request.content.body,
Expand Down
2 changes: 1 addition & 1 deletion local-notifications/ios/Plugin/LocalNotificationsPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public class LocalNotificationsPlugin: CAPPlugin {

let ret = ids.map({ (id) -> JSObject in
return [
"id": id
"id": Int(id) ?? -1
]
})
call.resolve([
Expand Down