Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google-maps): Update Clusters when moving map #1383

Closed
wants to merge 2 commits into from

Conversation

ItsChaceD
Copy link
Contributor

This PR addresses #1309, where (on android) clustering does not update when the map is moved, rotated, or zoomed in/out. It also allows modification of the minimum cluster size so behavior can be matched across all platforms.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types say 4 is the default for minClusterSize, but the default is only being set to 4 for web.
Is it 4 the default native value on Google Maps SDK? or should it be set to 4 there too if the minClusterSize option is not passed?

This should be two separate pull requests, one for the feat and another for the fix, or at least turn this into a feat PR.

@ItsChaceD ItsChaceD closed this Jan 30, 2023
@ItsChaceD
Copy link
Contributor Author

types say 4 is the default for minClusterSize, but the default is only being set to 4 for web. Is it 4 the default native value on Google Maps SDK? or should it be set to 4 there too if the minClusterSize option is not passed?

This should be two separate pull requests, one for the feat and another for the fix, or at least turn this into a feat PR.

Yes, you are right, they should be separate PRs. I split this into #1398 and #1399

And yes, 4 is the default native value for the Google Maps SDK on Android & iOS. I think this is different on web, so I explicitly set it to 4 if it is undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants