feat(pushnotifications): add support for Android 13 permissions #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as abuse.
This comment was marked as abuse.
|
Please, don’t ping me. see #1189 (comment) |
|
closing in favor of #1463 as this one includes changes for local-notifications and the push notifications code is incomplete |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for explicitly checking and requesting POST_NOTIFICATIONS permissions for Android 13 and above (SDK 33)
Tested it on Android 13 and works as expected. Android < 13 works as previously.
The current issue that this resolves is that when targeting SDK 32 then the permission request dialog is triggered at application launch and not when requested on an Android device running Android 13. Targeting SDK 33 does not ask for the permission at all.
Resolves #1135