feat(google-maps): provides variables for configuring dependencies #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theproducer
requested review from
jcesarmobile,
ItsChaceD,
IT-MikeS and
giralte-ionic
giralte-ionic
approved these changes
Jun 28, 2022
IT-MikeS
approved these changes
Jun 29, 2022
jcesarmobile
requested changes
Jun 30, 2022
There was a problem hiding this comment.
requested a few changes
also, all the variables should be documented in a new variables section in the readme with their default value (check camera readme as example)
google-maps/android/build.gradle
Outdated
| } | ||
|
|
||
| buildscript { | ||
| ext.kotlin_version = '1.6.10' | ||
| ext.kotlin_version = project.hasProperty("kotlinVersion") ? rootProject.ext.kotlinVersion : '1.7.0' |
There was a problem hiding this comment.
Suggested change
| ext.kotlin_version = project.hasProperty("kotlinVersion") ? rootProject.ext.kotlinVersion : '1.7.0' | |
| ext.kotlin_version = project.hasProperty("kotlin_version") ? rootProject.ext.kotlin_version : '1.7.0' |
Android Studio kotlin helper creates a variable named kotlin_version, so better use that one instead of our own kotlinVersion
google-maps/android/build.gradle
Outdated
| @@ -62,11 +68,11 @@ dependencies { | |||
| testImplementation "junit:junit:$junitVersion" | |||
| androidTestImplementation "androidx.test.ext:junit:$androidxJunitVersion" | |||
| androidTestImplementation "androidx.test.espresso:espresso-core:$androidxEspressoCoreVersion" | |||
| implementation "androidx.core:core-ktx:1.6.0" | |||
| implementation "androidx.core:core-ktx:$androidxKotlinVersion" | |||
There was a problem hiding this comment.
Suggested change
| implementation "androidx.core:core-ktx:$androidxKotlinVersion" | |
| implementation "androidx.core:core-ktx:$androidxCoreKTXVersion" |
We already have a variable for core-ktx (used by the CLI if there are cordova plugins that use kotlin), better use the same for consistency
google-maps/android/build.gradle
Outdated
| @@ -3,10 +3,16 @@ ext { | |||
| androidxAppCompatVersion = project.hasProperty('androidxAppCompatVersion') ? rootProject.ext.androidxAppCompatVersion : '1.4.2' | |||
| androidxJunitVersion = project.hasProperty('androidxJunitVersion') ? rootProject.ext.androidxJunitVersion : '1.1.3' | |||
| androidxEspressoCoreVersion = project.hasProperty('androidxEspressoCoreVersion') ? rootProject.ext.androidxEspressoCoreVersion : '3.4.0' | |||
| androidxKotlinVersion = project.hasProperty('androidxKotlinVersion') ? rootProject.ext.androidxKotlinVersion : '1.8.0' | |||
There was a problem hiding this comment.
Suggested change
| androidxKotlinVersion = project.hasProperty('androidxKotlinVersion') ? rootProject.ext.androidxKotlinVersion : '1.8.0' | |
| androidxCoreKTXVersion = project.hasProperty('androidxCoreKTXVersion') ? rootProject.ext.androidxCoreKTXVersion : '1.8.0' |
We already have a variable for core-ktx (used by the CLI if there are cordova plugins that use kotlin), better use the same for consistency
jcesarmobile
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.