fix(push-notifications): use id and tag for canceling active notification #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theproducer
requested review from
jcesarmobile,
ItsChaceD,
IT-MikeS and
giralte-ionic
giralte-ionic
approved these changes
Jun 14, 2022
jcesarmobile
requested changes
Jun 15, 2022
There was a problem hiding this comment.
Since getDeliveredNotifications now returns the notification tag, the types should be edited to reflect that, the tag should be optional and documented that it's only returned for Android push notifications (getDeliveredNotifications also returns local notifications, but they don't usually have a tag)
...android/src/main/java/com/capacitorjs/plugins/pushnotifications/PushNotificationsPlugin.java
Show resolved
Hide resolved
| * | ||
| * Only available on Android (from push notifications). | ||
| * | ||
| * @since 1.0.9 |
There was a problem hiding this comment.
Suggested change
| * @since 1.0.9 | |
| * @since 4.0.0 |
This will be available on version 4.0.0 of the plugin
jcesarmobile
requested changes
Jun 16, 2022
| Integer id = notif.getInteger("id"); | ||
| ids.add(id); | ||
| String tag = notif.getString("tag"); | ||
| Integer id = notif.getInteger("id", 0); |
There was a problem hiding this comment.
The id is not optional, so you shouldn't need the default value.
Have you seen it being null?
There was a problem hiding this comment.
not really, I removed it.
jcesarmobile
approved these changes
Jun 16, 2022
IT-MikeS
approved these changes
Jun 16, 2022
hmaretic24
pushed a commit
to hmaretic24/capacitor-plugins
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where it was not possible to delete individual notifications on Android.
closes: #740