fix(local-notifications): Make getPending not return already fired no…

…tifications (#256)

* Set visibility flag on LocalNotification, filter pendingNotification list

* Removing visible flag, just delete notification if its not rescheduled

Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>

local-notifications/android/src/main/java/com/capacitorjs/plugins/localnotifications/LocalNotification.java

@@ -33,7 +33,6 @@ public class LocalNotification {
     private List<LocalNotificationAttachment> attachments;
     private LocalNotificationSchedule schedule;
     private String channelId;
-
     private String source;
 
     public String getTitle() {

local-notifications/android/src/main/java/com/capacitorjs/plugins/localnotifications/TimedNotificationPublisher.java

@@ -36,10 +36,12 @@ public void onReceive(Context context, Intent intent) {
         JSObject notificationJson = storage.getSavedNotificationAsJSObject(Integer.toString(id));
         LocalNotificationsPlugin.fireReceived(notificationJson);
         notificationManager.notify(id, notification);
-        rescheduleNotificationIfNeeded(context, intent, id);
+        if (!rescheduleNotificationIfNeeded(context, intent, id)) {
+            storage.deleteNotification(Integer.toString(id));
+        }
     }
 
-    private void rescheduleNotificationIfNeeded(Context context, Intent intent, int id) {
+    private boolean rescheduleNotificationIfNeeded(Context context, Intent intent, int id) {
         String dateString = intent.getStringExtra(CRON_KEY);
         if (dateString != null) {
             DateMatch date = DateMatch.fromMatchString(dateString);
@@ -50,6 +52,9 @@ private void rescheduleNotificationIfNeeded(Context context, Intent intent, int
             alarmManager.setExact(AlarmManager.RTC, trigger, pendingIntent);
             SimpleDateFormat sdf = new SimpleDateFormat("yyyy/MM/dd HH:mm:ss");
             Logger.debug(Logger.tags("LN"), "notification " + id + " will next fire at " + sdf.format(new Date(trigger)));
+            return true;
         }
+
+        return false;
     }
 }