Js controller7 compatibility #763
Conversation
| for (const objectDevice in objectDevices) { | ||
| this.deleteDevice(objectDevice); | ||
| } | ||
| // const objectDevices: ioBroker.DeviceObject[] = await this.getDevicesAsync(); |
There was a problem hiding this comment.
If I understand correctly, commenting this out can result in stale devices not bee cleaned.
We should maybe address this in a follow up issue
There was a problem hiding this comment.
Simply REMOVING deleteDevice is no solution (in my oppinion). You should use the supported methods to delete an object instead.
There was a problem hiding this comment.
I added this method in the PR, but at 4 a.m., when my IOB restarted, I was woken up by my Ring alerts going off with messages like: ‘There is someone at the door!’ 😂 This happened because all the datapoints were deleted and then rebuilt. So, I quickly went back and commented out that part. I’ll take a closer look later.
There was a problem hiding this comment.
Of course deleting ALL states is a bad idea as this would delete all custom settings (i.e. history) too ...
Thanks for checking and sleep well :-)
There was a problem hiding this comment.
This initial "clean up" is a leftover from first adapter implementation from previous repo owner.
Of course a better/cleaner solution would be to e.g. communicate with api and cross reference those devices with the one's in object tree, thus allowing to only delete indeed removed devices.
Or adding an option in adapter settings menu to "Remove old/unreachable devices".
As this PR removes those old lines I did comment about it in the Code-Review, but as previously stated we can address it in a separate issue 👍
theimo1221
merged commit 526332a
into
iobroker-community-adapters:master
Fixes #707