-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added usage_guide.ipynb #27
Conversation
Desc. With this commit, I have added the contributing guidelines for new contributors.
Getting changes from pyobis/master
Desc. I have added the usage_guide.ipynb trying to resolve iobis#15 partly.
Desc. With this commit I have updated the colab badge to open this notebook straight into Google Colab
CONTRIBUTING.md
Outdated
- Proposing new features | ||
- Becoming a maintainer | ||
|
||
## We Develop with Github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor (really minor) correction :-)
## We Develop with Github | |
## We Develop with GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ocefpaf for the review! I will update these corrections.
CONTRIBUTING.md
Outdated
## We Develop with Github | ||
We use github to host code, to track issues and feature requests, as well as accept pull requests. | ||
|
||
## We Use [Github Flow](https://guides.github.com/introduction/flow/index.html), So All Code Changes Happen Through Pull Requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## We Use [Github Flow](https://guides.github.com/introduction/flow/index.html), So All Code Changes Happen Through Pull Requests | |
## We Use [GitHub Flow](https://guides.github.com/introduction/flow/index.html), So All Code Changes Happen Through Pull Requests |
CONTRIBUTING.md
Outdated
## We Use [Github Flow](https://guides.github.com/introduction/flow/index.html), So All Code Changes Happen Through Pull Requests | ||
Pull requests are the best way to propose changes to the codebase (we use [Github Flow](https://guides.github.com/introduction/flow/index.html)). We actively welcome your pull requests: | ||
|
||
1. Fork the repo and create your branch from `master`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Fork the repo and create your branch from `master`. | |
1. Fork the repo and create your branch from `main`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ocefpaf for the review! Actually, we have master
as the HEAD upstream for this repo. Maybe this was older than when GitHub introduced the change of nomenclature. Should I do away with this change?
CONTRIBUTING.md
Outdated
We use github to host code, to track issues and feature requests, as well as accept pull requests. | ||
|
||
## We Use [Github Flow](https://guides.github.com/introduction/flow/index.html), So All Code Changes Happen Through Pull Requests | ||
Pull requests are the best way to propose changes to the codebase (we use [Github Flow](https://guides.github.com/introduction/flow/index.html)). We actively welcome your pull requests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull requests are the best way to propose changes to the codebase (we use [Github Flow](https://guides.github.com/introduction/flow/index.html)). We actively welcome your pull requests: | |
Pull requests are the best way to propose changes to the codebase (we use [GitHub Flow](https://guides.github.com/introduction/flow/index.html)). We actively welcome your pull requests: |
CONTRIBUTING.md
Outdated
By contributing, you agree that your contributions will be licensed under [this License](https://github.com/iobis/pyobis/blob/master/LICENSE). | ||
|
||
## References | ||
This document was adapted from the open-source contribution guidelines for [Facebook's Draft](https://github.com/facebook/draft-js/blob/a9316a723f9e918afde44dea68b5f9f39b7d9b00/CONTRIBUTING.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dopplershift (pinging here just for credit), made some awesome docs on contributing, opening issues, PRs, etc, that could serve an inspiration here. See https://github.com/Unidata/MetPy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ocefpaf for the resource! I'll get some insights from there and update the document.
Edit: Oh, I just saw #26 and it seems that you just pull those commits here. |
Regarding the notebook:
res=nodes.activities(id="4bf79a01-65a9-4db6-b37b-18434f26ddfc")
print(res["results"])
print(pd.DataFrame(res["results"]))
|
The separation of context helps to avoid conflicts. If this PR only edits the notebook and the other one the markdown contributing file, we should be OK. |
I will update the notebook accordingly. Actually, for some results a pandas DataFrame doesn't speak much due to the huge volume of columns and few rows. I am thinking of keeping the raw response for some (cleaned up as a dictionary) and pandas DataFrame for some.
I was thinking to keep this notebook only for explaining about the functions inside modules, and their input parameters. Analyzing data through each function might make this notebook bit heavy, so I thought of diving deep into each module in a separate notebook. How should I approach this? |
Noted. I'll make sure about this for future. |
Uh oh. It looks like
Whichever way is easiest is fine. 🩹 We are going to have to practice this workflow a few times until we get it perfected. |
Thanks @7yl4r! I am going to remove CONTRIBUTING.md from this PR and inculcate changes suggested by you and @ocefpaf in #26. I'll make sure I don't mix up PRs in future. |
I think the best approach here would have been to base a new fork off of the latest in the master. One critical piece that may be missing is using |
Desc. I am removing CONTRIBUTING.md to make cleaner PRs
Thanks a ton @7yl4r! I actually didn't have a sound practice with |
It is something to be careful with, since rebasing does edit history. It makes me nervous too, but unfortunately it seems to be essential to the typical git PR workflow. |
I'm learning new things every day, and this journey hasn't been so good before. And I have so much more to learn. Thank you so much! |
Overview
This PR aims to resolve #15 partly by
usage_guide.ipynb
notebook containing examples for prospective pyobis users.Notes for Reviewers
This PR is two commits ahead of #26 (one change ahead).
Next Steps
I will now be working on creating Jupyter Notebooks for analyzing and visualizing data grabbed through occurrences.search()