Changelog Update and getting back changes undone to resolve merge conflicts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desc. With this commit I am reverting all the changes I had to undo when resolving merge conflicts.
Desc. Replaced branch name [main] with [master].
Desc. With this commit I have updated the Changelog.rst. + Updated the version to 1.0.0 + Added description of changes
7yl4r
requested changes
Jul 11, 2022
| :target: https://github.com/iobis/pyobis/actions/workflows/tests.yml | ||
|
|
||
| .. |coverage| image:: https://coveralls.io/repos/sckott/pyobis/badge.svg?branch=master&service=github | ||
| :target: https://coveralls.io/github/sckott/pyobis?branch=master |
There was a problem hiding this comment.
This is pointing to the wrong repo. Need to update the url or remove the coveralls badge.
There was a problem hiding this comment.
Thanks @7yl4r for the review! I will update the URL.
There was a problem hiding this comment.
I couldn't find a way to update this a coveralls.io badge, maybe we need to register this repo at coveralls.
ocefpaf
reviewed
Jul 11, 2022
README.rst
Outdated
| @@ -118,8 +113,8 @@ Meta | |||
| .. |docs| image:: https://readthedocs.org/projects/pyobis/badge/?version=latest | |||
| :target: http://pyobis.readthedocs.org/en/latest/?badge=latest | |||
|
|
|||
| .. |tests| image:: https://github.com/iobis/pyobis/actions/workflows/tests.yml/badge.svg | |||
| .. |tests| image:: https://github.com/ayushanand18/pyobis/actions/workflows/tests.yml/badge.svg | |||
There was a problem hiding this comment.
Please point all status check to the upstream repo and not your fork.
There was a problem hiding this comment.
Thank you @ocefpaf for the review! I am sorry I just missed updating this, I was testing whether the badge works or not but forgot to update it later. I'll make the necessary changes.
Desc. I have updated the test status check badge on the README to point the upstream repo-> iobis/pyobis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Changes
This pull request tries to resolve #24
With this PR we have got three objectives accomplished:
Notes for reviewers
The tests are passing for this PR with nearly 84% overall coverage and 100% coverage for all modules.
Next Steps
I am now working on Contributing guidelines.