Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #589: Update README.md #590

Closed
wants to merge 1 commit into from
Closed

Fix for #589: Update README.md #590

wants to merge 1 commit into from

Conversation

ANierbeck
Copy link

the test function needs to call the done method, otherwise tests always fail

@ANierbeck
Update README.md
9ebdeb8 
Fix for ioBroker.tests issue ioBroker#589
AlCalzone
AlCalzone requested changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should investigate why the original code isn't working for you. Returning a promise is the modern alternative to using done().

This change is not the way to do it.

@Apollon77
Copy link
Collaborator

@ANierbeck Please provide more details or maybe a link to your tests where it does not work

@AlCalzone
Copy link
Collaborator

See #589

@ANierbeck
Copy link
Author

See comment in #589, let's ignore this

@ANierbeck ANierbeck closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ANierbeck @Apollon77 @AlCalzone