Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Process only unprocessed tags in recursion #103

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

candiduslynx
Copy link
Contributor

Regression from #101

@candiduslynx candiduslynx force-pushed the fix/recurse-array-unprocessed-only branch from 910f04b to 0bfcdd9 Compare September 26, 2023 17:12
@candiduslynx candiduslynx force-pushed the fix/recurse-array-unprocessed-only branch from 0bfcdd9 to 9c0d982 Compare September 26, 2023 17:14
@candiduslynx
Copy link
Contributor Author

@samlown I've tested our case with this code & it works OK (apart from #102), so I'd love to get a release after the PR is merged

@candiduslynx
Copy link
Contributor Author

candiduslynx commented Sep 27, 2023

@samlown it would be great to get review & release this week

Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samlown samlown merged commit d8087c4 into invopop:main Sep 28, 2023
2 checks passed
@candiduslynx
Copy link
Contributor Author

@samlown could you also create a tag/release?

kodiakhq bot pushed a commit to cloudquery/codegen that referenced this pull request Oct 2, 2023
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Oct 2, 2023
@candiduslynx candiduslynx deleted the fix/recurse-array-unprocessed-only branch October 3, 2023 12:26
hydratim pushed a commit to hydratim/cloudquery that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants