Validate xml against xsd #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure that the xml we are generating is valid we want to validate it againts the provided xsd. This will also make it simpler to find changes if the KSeF API changes. To validate the xml we will be using go-xsd-validate package so we add it into the project. We also use this opportunity to do a little cleanup and remove all not used packages.
There are some optional fields in our current invoice that are being left empty. This creates an invoice that is not valid and will not be accepted by the KSeF API. To make the invoice valid we remove ExchangeRate, FP, TP fields until we are able to populate them with correct values.
To make sure that the xml we are generating is valid we check it againts a xsd file. We add the current FA2 version of the xsd. This will allow us to validate our invoice for any new version of KSeF.
noplisu
force-pushed
the
gl-validate-xml-againts-xsd
branch
from
27d5495
to
82f5027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
To make sure that the xml we are generating is valid we want to validate it againts the provided xsd. This will also make it simpler to find changes if the KSeF API changes. To validate the xml we will be using go-xsd-validate package. To make the invoice valid we remove ExchangeRate, FP, TP fields until we are able to populate them with correct values.