Add tests for gobl to ksef conversion #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR adds some basic tests to the GOBL to KSeF conversion. We also do some cleanup in the test folder structure for it to mirror the implementation from gobl.cfdi. This changes allow us to move and adjust some test helper methods from gobl.cfdi for our tests.
For the tests to work we had to comment out some of the payments code. The issue with this code will be addressed in future PRs.
The last change is adding vscode settings to .gitignore since we don't want to have them in the repository
Feedback
There will be more tests added after this but I decided to create a PR with those 2 for a start. The next test will be a validation of the generated xml file against a xsd file, but the current draft of this test returns errors in our implementation that will need to be addressed with the test itself so I decided that it merits a PR for itself.