Add tests for gobl to ksef conversion #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since I am working using vscode and have some custom settings for running tests, running and debugging go code I don't want those settings to be commited to not pollute the repository and not break any settings for other people. To do that I add the .vscode folder to the .gitignore file.
Before we add tests we want to change the structure of the test directory. This new strucutre is based on the structure we have in glob.cfdi. This will allow us to use the same helper methods in both projects.
To keep tests clean we add a test.go file into the test folder. In this file we will keep helper functions that will help us load example gobl data that we will be using in our tests. This approach is mimicking the approach we have in gobl.cfdi.
In the test golb structure there is no payments data. Passing this data into our KSeF parser results in an error. Since the payment data is optional in KSeF we decided to comment out this part of the code and address the issue after we add some tests to the existing code.
We are finally ready to add the first test to the golb KSeF parser. Here we test the basic XML structure generated in the ksef.go file.
As we want to be sure that the KSeF document is generated correctly we add a test that checks if the generated KSeF xml is the same as a KSeF xml in the out folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR adds some basic tests to the GOBL to KSeF conversion. We also do some cleanup in the test folder structure for it to mirror the implementation from gobl.cfdi. This changes allow us to move and adjust some test helper methods from gobl.cfdi for our tests.
For the tests to work we had to comment out some of the payments code. The issue with this code will be addressed in future PRs.
The last change is adding vscode settings to .gitignore since we don't want to have them in the repository
Feedback
There will be more tests added after this but I decided to create a PR with those 2 for a start. The next test will be a validation of the generated xml file against a xsd file, but the current draft of this test returns errors in our implementation that will need to be addressed with the test itself so I decided that it merits a PR for itself.