Fix Timber for Error objects #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunar
force-pushed
the
gcg/fix-timber
branch
from
48ca009
to
703dddc
Compare
|
@gunar you can test Postman by installing the library straight from this branch. |
kewitz
approved these changes
Sep 26, 2018
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| *v3.0.0* | |||
| > Internal: Serialize error objects | |||
| > Internal: Rename `event` key on-the-fly | |||
There was a problem hiding this comment.
Why major, is this a breaking change?
gunar
force-pushed
the
gcg/fix-timber
branch
from
703dddc
to
07a3c7e
Compare
gunar
changed the title
event key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this finally does it.
If we used Lerna I could've done it all in one PR.
Now I've got to merge this first, then experiment on postman staging.
Not even patch-package was able to help me this time.
I tried to run experiments on staging based on patch-package but it seems it
has a problem with named packages (e.g. *@invisible/*logger).