fix cancelAlarm on android

[matttti]

I noticed that firebase.notifications().cancelAllNotifications() has no effect on android phones. All scheduled notifications still appear. The propsed change fixes this. It was "inspired" by https://stackoverflow.com/questions/35341682/cancel-the-scheduled-android-notification/35342066#35342066

[chrisbianca]

Great catch! Thanks for highlighting and submitting the PR - we'll get this into the 4.0.1 release

[ghost]

@chrisbianca - I am not able to remove delivered notification with notificationId also. I am using this for Android OS. I have updated the react-native-firebase to 4.0.1 The code flow that I am using -

const notificationOpen: NotificationOpen = await firebase.notifications().getInitialNotification();
await firebase.notifications().removeDeliveredNotification(notificationOpen.notification._notificationId);
const notificationOpenAgain: NotificationOpen = await firebase.notifications().getInitialNotification();

I am still able to access notification from notificationOpenAgain.notification with the same notification ID. Not sure, if this is an expected behaviour, or a bug, since documentation doesn't explicitly states that. Please let me know if you need any more information from me. Thanks!

[chrisbianca]

@credifiable removeDeliveredNotification will prevent the notification from showing in the native device tray any more. getInitialNotification will always be populated with the notification that was used to start the app - there is no way to clear this by design.

[hanzoow]

hi @matttti , can you show me how to save your changes into this repo and make sure that after npm install i still got my own changed codes back ? ex i call removeDeliveredNotificationsByTag function from native in dist folder in node_modules after npm install. I did fork this repo and try to find the function that i can make some changes into but i can't. So how we can save changes in react-native-firebase in node_modules and then if another devices use npm install, there will be my changes ? Plz help i need it really bad !

[mikehardy]

@hanzoow patch-package https://github.com/ds300/patch-package - it's fantastic

[hanzoow]

@hanzoow patch-package https://github.com/ds300/patch-package - it's fantastic

hi ! after generate react-native-firebase+5.6.0 file, what should i do next with this file ? Please guide me

[mikehardy]

I will not guide you. You will read the patch-package documentation.

[hanzoow]

I will not guide you. You will read the patch-package documentation.

yeah thank you for the recommend ! i did it.