Remove error log from RNFirebaseRemoteConfig #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave it up to the consumer of the library to handle any errors instead of forcing a red error screen. In case the app is offline, it is perfectly fine to get a FIRRemoteConfigErrorInternalError error.
|
This seems reasonable, thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the app is offline and the consumer of this library is using Remote Config, it is perfectly fine to get a
FIRRemoteConfigErrorInternalErrorerror, but there is really no reason to show a red error while developing.Instead, we should leave it up to the consumer of this library to handle any errors.
It seems that only that only
RNFirebaseRemoteConfig.mshould be fixed to not useRCTLogErrorwhere we also reject.RNFirebaseMessaging.mis also usingRCTLogErrorbut actual errors wherehere is no completion handler with completionHandlerId.