Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): fix patch set generation to handle modern react-native / yarn #7792

Merged
merged 4 commits into from
May 14, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

react-native 0.74+ tries to init a git repository which doesn't work well for us in CI
react-native 0.74+ uses yarn3+ by default which has 3 problems with our usage:

  • it needs --dev not --save-dev to install a devDependency
  • you have to turn off immutability (on by default in CI) for it to init a project like we do
  • it does not handle executable bits correctly of our ios_config.sh scripts during the pack of our modules

Release Summary

conventional commits

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Extensive testing during development. After merge, should rebase this out of #7565 and #7774 where pieces of it are also present


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label May 14, 2024
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 9:05pm

@mikehardy
Copy link
Collaborator Author

Investigation of the patch set reveals exactly the contents I expect, nothing I don't expect https://github.com/invertase/react-native-firebase/actions/runs/9086125300?pr=7792

@mikehardy mikehardy merged commit cfd6f19 into main May 14, 2024
15 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/fix-patchset-generation branch May 14, 2024 21:09
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant