Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth,android): Pass firebaseAuth into OAuthProvider.newBuilder(...) #7677

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix(auth,android): Pass firebaseAuth into OAuthProvider.newBuilder(...) #7677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8164344
fix(auth,android): Pass firebaseAuth into OAuthProvider.newBuilder(...)
lanpai Mar 11, 2024
ba9a937
Fix function arguments elsewhere
lanpai Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .../auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,9 @@ private void signInWithProvider(String appName, ReadableMap provider, final Prom
return;
}

OAuthProvider.Builder builder = OAuthProvider.newBuilder(provider.getString("providerId"));
OAuthProvider.Builder builder = OAuthProvider.newBuilder(
provider.getString("providerId"),
firebaseAuth);
// Add scopes if present
if (provider.hasKey("scopes")) {
ReadableArray scopes = provider.getArray("scopes");
Expand Down Expand Up @@ -1648,7 +1650,9 @@ private void linkWithProvider(String appName, ReadableMap provider, final Promis
return;
}

OAuthProvider.Builder builder = OAuthProvider.newBuilder(provider.getString("providerId"));
OAuthProvider.Builder builder = OAuthProvider.newBuilder(
provider.getString("providerId"),
firebaseAuth);
// Add scopes if present
if (provider.hasKey("scopes")) {
ReadableArray scopes = provider.getArray("scopes");
Expand Down Expand Up @@ -1791,7 +1795,9 @@ private void reauthenticateWithProvider(
return;
}

OAuthProvider.Builder builder = OAuthProvider.newBuilder(provider.getString("providerId"));
OAuthProvider.Builder builder = OAuthProvider.newBuilder(
provider.getString("providerId"),
firebaseAuth);
// Add scopes if present
if (provider.hasKey("scopes")) {
ReadableArray scopes = provider.getArray("scopes");
Expand Down
Loading