Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ci): do not pre-compress logs sent to upload-archive action #7478

Merged
merged 1 commit into from
Nov 28, 2023
Merged

test(ci): do not pre-compress logs sent to upload-archive action #7478

merged 1 commit into from
Nov 28, 2023

Conversation

chipitsine
Copy link
Contributor

GHA artifacts are already compressed using zip, no need to compress them twice

@chipitsine
CI: do not compress simulator logs
213a197 
GHA artifacts are already compressed using zip, no need to compress them twice
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 10:14am
react-native-firebase-next ❌ Failed (Inspect) Nov 28, 2023 10:14am

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mikehardy
mikehardy approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Keep forgetting to remove this doubling (which annoys me every time I have to double-unpack them for inspection...)

Even the tiny things need the CLA signed though if you could take a moment? 🙏

Much appreciated

@chipitsine
Copy link
Contributor Author

CLA bot told me "you have signed already..."
looks like nothing left from my side

@mikehardy mikehardy changed the title CI: do not compress simulator logs test(ci): do not pre-compress logs sent to upload-archive action Nov 28, 2023
@mikehardy
Copy link
Collaborator

Verified: indeed the android workflow already completed and it's emulator log came through nicely zipped as expected. I'm certain iOS will follow suit

@mikehardy mikehardy merged commit c368a82 into invertase:main Nov 28, 2023
13 of 17 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chipitsine @CLAassistant @mikehardy