build(ios): specify script runs every time, fix crashlytics input file path #7472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Seeing behavior in CI that I did not see locally - the warning is still showing up about the script running each time. Very unexpected, need to investigate |
this removes the ambiguity of whether they need to run every time or not, which caused xcodebuild to emit a warning if ambiguous, xcodebuild runs them every time which is our desired behavior, this behavior will continue as before but now without the warning message
I believe it had an incorrect path segment prepended to it, now the input file matches the app module input file path
this have no value and clutter the build log
these are noisy in the build log, and we only care about our own script phase warnings - the ones about detox, react-native and copying headers are noise not signal
mikehardy
force-pushed
the
@mikehardy/run-script-preening
branch
from
cbed4c9 to
3d5842a
Compare
|
Definitely seeing expected results now, and was able to quiet a few other items as well so the build is pretty peaceful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple small tweaks to our run scripts so they operate more smoothly + quietly
Related issues
Release Summary
conventional commits
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Checked behavior of the
always_out_of_dateattr locally, plus you can see in the pod-generated xcodeproj that it was carried through correctly.Checking the build log confirms that the previous warnings about the run script phase always running are no longer present
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter