Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(auth): fix docs render issue in AuthSettings #7201

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

mikehardy
Copy link
Collaborator

Description

unterminated tag was breaking Vercel docs build, I should have caught that on the PR review, it was obvious in hindsight

Related issues

Fixes #7166
Originally caused by #7148 but obviously not on purpose, it was a trivial error that correctly triggered status failures etc

Release Summary

no package release, just a docs change, but Vercel will build + deploy which is all I want

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Run of cd website && yarn then repeats of yarn build with some instrumentation until I located the issue


Think react-native-firebase is great? Please consider supporting the project with any of the below:

unterminated tag was breaking Vercel docs build, I should have caught that on
the PR review, it was obvious in hindsight
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jun 27, 2023
@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 1:31am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
react-native-firebase-next ⬜️ Ignored (Inspect) Jun 27, 2023 1:31am

@mikehardy
Copy link
Collaborator Author

Vercel built! Yes. This does not effect iOS or Android and those are the only 2 checks left. As those are unimportant for this PR I'm merging so our docs site is up to date (with new realtime remote-config info...)

@mikehardy mikehardy merged commit 63fc8ef into main Jun 27, 2023
@mikehardy mikehardy deleted the @mikehardy/fix-docs branch June 27, 2023 01:43
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate intermittent Vercel deployment failure
1 participant