fix: *merge* setting to true irrespective of value passed

[snehsagarajput]

Description

merge option is being set to true, even if false is passed! This can result in unexpected results!
As per documentations, SetOptions merge can be one of "undefined", "true" or "false". But in the current implementation the false(boolean) value is mistreated as true only!
Fixed the SetOptions merge to handle false value.

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• This is a breaking change;
  • Yes
  • No

[CLAassistant]

All committers have signed the CLA.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-native-firebase	✅ Ready (Inspect)	Visit Preview	Jul 31, 2022 at 8:22PM (UTC)

1 Ignored Deployment

Name	Status	Preview	Updated
react-native-firebase-next	⬜️ Ignored (Inspect)		Jul 31, 2022 at 8:22PM (UTC)

[mikehardy]

oh my, that's a laughably obvious issue, really sorry that crept in the library. Thanks so much for posting a patch.

Have you tried this (via patch-package patch or similar) in production and it's working for you?

[snehsagarajput]

oh my, that's a laughably obvious issue, really sorry that crept in the library. Thanks so much for posting a patch.

Have you tried this (via patch-package patch or similar) in production and it's working for you?

Haven't tried it using any library but tested it once by directly changing the library code!
@mikehardy

[codecov]

Codecov Report

Merging #6436 (4e6db6b) into main (b062e74) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 4e6db6b differs from pull request most recent head 6015835. Consider uploading reports for the commit 6015835 to get more accurate results

@@           Coverage Diff           @@
##             main    #6436   +/-   ##
=======================================
  Coverage   25.83%   25.83%           
=======================================
  Files          97       97           
  Lines        4291     4291           
  Branches     1048     1048           
=======================================
  Hits         1108     1108           
  Misses       2583     2583           
  Partials      600      600