Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios, messaging): depend directly on FirebaseCoreExtension pod #6405

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

mikehardy
Copy link
Collaborator

Description

Messaging is having a build failure currently, it needs a direct dependency on the FirebaseCoreExtension pod apparently, if you use the pod without storage, functions or @react-native-firebase/crashlytics (which has the dep already)

This may affect other RNFB modules as well, no attempt has been made yet to triage other modules built in isolation (that is, with @react-native-firebase/app only)

Related issues

Fixes #6403
Related #6352

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Perhaps @LozytskyiA can check the result of the patch-package action here


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jul 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 5:33AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Jul 19, 2022 at 5:33AM (UTC)

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #6405 (59edfab) into main (71dee2b) will decrease coverage by 2.27%.
The diff coverage is n/a.

❗ Current head 59edfab differs from pull request most recent head 095b4a6. Consider uploading reports for the commit 095b4a6 to get more accurate results

@@             Coverage Diff              @@
##               main    #6405      +/-   ##
============================================
- Coverage     56.76%   54.50%   -2.26%     
  Complexity      679      679              
============================================
  Files           193      208      +15     
  Lines          8995    10356    +1361     
  Branches        597     1645    +1048     
============================================
+ Hits           5105     5643     +538     
- Misses         3684     4432     +748     
- Partials        206      281      +75     

@mikehardy mikehardy force-pushed the @mikehardy/messaging-needs-FirebaseCoreExtension branch from fc22c69 to 095b4a6 Compare July 19, 2022 05:28
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Aug 7, 2022
@mikehardy mikehardy merged commit 62ee54b into main Aug 7, 2022
@mikehardy mikehardy deleted the @mikehardy/messaging-needs-FirebaseCoreExtension branch August 7, 2022 18:37
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module 'FirebaseCore' not found
1 participant