Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging): add missing PRIORITY_MIN value it JS part #6033

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Jan 26, 2022

Description

messaging.NotificationAndroidPriority.PRIORITY_MIN was undefined

Related issues

Fixes #6027

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jan 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/2foXBaeHK5kLhWR8MNwpavF9c5LB
✅ Preview: Canceled

[Deployment for 16e9c72 canceled]

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/8fhioDBcAnrFq6xfjVgmsxZEe1JS
✅ Preview: https://react-native-firebase-git-fork-retyui-fix-mess-d5706f-invertase.vercel.app

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #6033 (2257445) into main (6f67503) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 2257445 differs from pull request most recent head 16e9c72. Consider uploading reports for the commit 16e9c72 to get more accurate results

@@             Coverage Diff              @@
##               main    #6033      +/-   ##
============================================
- Coverage     53.00%   52.95%   -0.04%     
+ Complexity      628      623       -5     
============================================
  Files           208      208              
  Lines         10195    10195              
  Branches       1619     1619              
============================================
- Hits           5403     5398       -5     
- Misses         4541     4542       +1     
- Partials        251      255       +4     

@andersonaddo
Copy link
Contributor

You made a syntax error
Builds and lints are failing because of this; you're gonna have to fix that before we merge

@retyui
Copy link
Contributor Author

retyui commented Jan 26, 2022

@andersonaddo thanks that notice, Fixed

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right on (based on a check of the related issue, and then looking here) - thanks for noticing this and posting the PR!
@andersonaddo thanks a bunch for the timely assist, I really appreciate it

@mikehardy mikehardy merged commit d34112a into invertase:main Jan 26, 2022
@mikehardy
Copy link
Collaborator

working up to a release right now, this should be on npmjs.com in a half hour or so after CI runs on main branch post-merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛][TS] NotificationAndroidPriority.PRIORITY_MIN exists in types only
3 participants